Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main.go: controller generate gRPC endpoints #37

Merged
merged 1 commit into from
Jan 13, 2020
Merged

main.go: controller generate gRPC endpoints #37

merged 1 commit into from
Jan 13, 2020

Conversation

squat
Copy link
Member

@squat squat commented Jan 13, 2020

This commit updates the controller to generate gRPC endpoints rather
than HTTP endpoints, following
thanos-io/thanos#1970.

Signed-off-by: Lucas Servén Marín [email protected]

cc @kakkoyun @metalmatze

kakkoyun
kakkoyun approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

metalmatze
metalmatze approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@squat
main.go: controller generate gRPC endpoints
c3125b9 
This commit updates the controller to generate gRPC endpoints rather
than HTTP endpoints, following
thanos-io/thanos#1970.

Signed-off-by: Lucas Servén Marín <[email protected]>
@squat squat merged commit c4e9017 into observatorium:master Jan 13, 2020
@squat squat deleted the gRPC branch January 13, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squat @kakkoyun @metalmatze